Skip to content

Curl 8.16 fixes #20093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 7, 2025
Merged

Curl 8.16 fixes #20093

merged 4 commits into from
Oct 7, 2025
+22 −18

Conversation

bukka
Copy link
Member

@bukka bukka commented Oct 7, 2025

This backports some previous fixes for curl 8.16 to 8.1 and fixes #19925 - failing curl_setopt_ssl test.

nielsdos and others added 4 commits October 7, 2025 12:04
@nielsdos @bukka
Fix curl build failure on macOS+curl 8.16
8b504c4
@iluuu1994 @bukka
Fix curl 8.16.0 compilation with zts
21d7334
@iluuu1994 @bukka
Fix more curl 8.16 issues
128e7e2 
The CURLOPT_FOLLOWLOCATION seems like a gcc bug, where the integer extension of
bool to long is lost, but I was unable to reproduce on godbolt.org.
@bukka
Fix curl_setopt_ssl test for curl 8.16
4486742
@bukka bukka changed the title Curl 8 16 fixes Curl 8.16 fixes Oct 7, 2025
This was referenced Oct 7, 2025
Closed
Closed
@bukka bukka linked an issue Oct 7, 2025 that may be closed by this pull request
PHP 8.5 started to fail ext/curl/tests/curl_setopt_ssl.phpt on alpinelinux with curl 8.16 #19925
Closed
@bukka
Copy link
Member Author

bukka commented Oct 7, 2025

Curl issues are fixed. The MacOS failure is about PTY:

========DIFF========
2190
001- read from pipe 0: string(5) "foo
2191
002- "
2192
001+ read from pipe 0: string(0) ""
2193
     read from pipe 3: string(3) "42
2194
     "
2195
========DONE========
2196
FAIL proc_open with PTY closes incorrect file descriptor [ext/standard/tests/file/bug69442.phpt]

@bukka bukka merged commit 36859ad into php:PHP-8.1 Oct 7, 2025
9 of 11 checks passed
@iluuu1994
Copy link
Member

iluuu1994 commented Oct 7, 2025 •
edited
Loading

This part was missing for 8.2: 1edcce5, should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PHP 8.5 started to fail ext/curl/tests/curl_setopt_ssl.phpt on alpinelinux with curl 8.16

3 participants

@bukka @iluuu1994 @nielsdos